Plus the task may be judging the "decisions" of a different kind of "contributor" than fellow humans, and often there's no social payoff for interacting and no trust that the contributor will internalize what you said and improve the next time.
I think this is a muscle that grows though. Making decisions about schema changes in the past may have taken weeks, but if you're doing it once or twice a week you gradually gain confidence in your judgment.
Does it really though? Before I had to think hard before committing to a decision, because it took work to actually implement it. And when it turned out to be wrong, I retained how it went wrong. It made the "muscle" grow.
Now I can commit to a decision without much thought (yea, just nodding along with the AI), and if it turns out to be wrong, I can quickly try an alternative. In fact, my boss would want to quickly try an alternative, instead of letting the programmer learn something out of it for fear of slowing down the AI...
I find it extremely exhausting. And the better the AI code gets, the more tempting it is to do a very shallow review or skip it entirely. In the end, it's very similar to dealing with offshore teams. You spend an enormous amount of time and energy on writing specifications and you spend a lot of energy on code reviews. If you don't do that, it's very likely the project will slowly go off the rails.
I have no idea how the Linux maintainers do that job over a long time.
The irony is that I actually don't mind reviewing code, but I've already taken that step out of the equation using a set of guidelines I've developed over the past year working with these things. The vast majority of which I have barely reviewed code in. In well-working results.
Your goal should be to automate and remove yourself out of the process as much as possible while maintaining quality, while also remaining confident that you will still be valuable.
Don't. If you try that shit, someone is not going to like that you would be slowing down the AI. Because out there, someone is going to outrun you by skipping reviews. That is how the leadership thinks..
You're reviewing _something_ at the end of the day. (Unless you are somehow magically one-shotting problems) If you are reviewing the description of the work, or reviewing the functionality of the app.
I know it's not the same as code, but it is similarly exhausting
As long as stakes are high and human have to sign off quality and are held responsible for any faulty release, no one will be willing to speed this up.
A lot of this university research on AI feels dated. This is something we all faced months ago. Many times they're also reaching conclusions using obsolete models, etc. Feels like things move too fast for traditional research cycles to catch up to AI dev
Its not resolved though, by any measure, except by removing human code review and coherence at the code level. Which is a pretty big tradeoff that has some at this point well-known downsides.
hard to know where to start here. but I think it is sufficient to say you seem to misunderstand the fundamental purpose and process of academic research and may wish to avoid commenting on it until you do.
Not that I think most academic research is worth the time consumed producing it, but it feels dated because it actually takes time to do research instead of just rapidly changing direction based on feels, which is what developers are currently doing. It's the intellectual rigor of javascript frameworks, but with slop cannons.
In particular, code review is not solved. Pointing another error-prone bot at the output of your first error-prone bot, and then pressing "Enter" if the test suite passes, is not a solution. But you have to do it, because the next guy will beat you to prod if you don’t. And before too long, I'm sure that pressing Enter will be the bottleneck...
Right now what we have is a prisoner’s dilemma, where you can’t be slower than the guy next to you. So we rationalize slop and call it innovation.
Exactly. What a weird clickbait title to come out of a Tier 1 institution. You have Harvard PhD's concluding this!? This is what a PhD at that insitution is putting out? That is really sad. FTA:
The paper’s interviews show what that looks like on a team: a junior software engineer described a project where only one senior engineer could approve changes and could review the interviewee’s code only once a week.
So the issue is not AI. The issue is organizations and certain personalities who think that a human is going to be a better coder than an engineer. At this point rolling and writing your own code is akin to making up your own encryption scheme.
The problem is that when nobody writes code or feels ownership over it anymore, nobody will be qualified to or really interested in doing the code reviews. The way forward could involve dropping code reviews altogether. You could argue that the useful pingpong between coder and reviewers has been replaced by the similar pingpong between the prompter and the agent.
In my company, people found out that if they use an agent that commits and do the pull/merge request, they can approve it themselves and bypass a second set of eyes.
Since they are the one doing the prompting, they quickly got lazy of actually reviewing the output from the LLM which means that nobody is reviewing anything.
It hasn't happened yet but I guess that is how you end up with major outages.
This is everywhere to my knowledge, and engineers are burning out left and right with stress because of how little anyone understands the code, and how much of a mountain of nobody knowing anything they have to handle. We are turning our critical infrastructure mechanisms into stochastic grey goo.
I find the engineers currently thriving are the ones who never gave a fuck about anything but their own advancement and are happy to drop weeks of work on others and take the credit.
Everyone's doing code reviews--well, not even code reviews; just PR reviews--so how are they supposed to gain an understanding of the system.
I review a PR, I see that one new endpoint was added to the API. It looks correct. I say "LGTM" in a GitHub comment.
The sprint's almost over, everyone's in a rush to do code reviews.
I look at another PR. Somebody added a button to the UI. The button looks correct, it's connect to some callbacks that look correct. They get a thumbs-up emoji from me. I bet they feel satisfied.
I look at another PR. Somebody changed a timeout in the settings because some people complained about dropped connections. It's a really small change, so, approved.
At what point am I supposed to understand the system? I looked at a single API endpoint, in isolation, and then a button, and then a harmless looking settings change.
I was pressured to hurry.
Am I supposed to somehow get an understanding of the big picture through this?
Imagine if instead there was time to review large logical sections of the code together. Imagine if we focused our reviews on the overall code instead of on the lines in one random PR at a time.
Understanding is overrated, application code (user-space) is anyway just a way to make money. If you're making more money over time, you're doing it right. We're not writing kernel code or safety critical code, we can let AI do the heavy lifting of putting characters into a file.
"We're not writing kernel code or safety critical code"
I do. There is a lot of code out there that needs to work correctly or it will have serious consequences. Payments, inventory tracking, medical stuff, payroll. Many, many areas where it just needs to work.
There are plenty of apps that while not safety critical, are financially critical to people's lives. When you're working on an app that processes billions of dollars in payments per month you can't just yolo it.
This is why we need to resurrect the neglected git-blame and go back to the days of git-before-GitHub. Way back in the old timey days of 2009-ish, just before the Dawn of the Pull Request, code reviews were seldom. Maybe you’d all get a conference room and talk about architecting some new thing or whatever, but none of this endless nit-picking bullshit that came later. And there were no branch protections, anyone could crap all over the main branch (nee: master) anytime they wanted. Boy, those were some wild times, let me tell ya!
Truth be told, it was the firm hand of the git blame-and-shame that kept our code civil and orderly. Binding contract written in blood was “the name on the blame owns the change”. If you pushed it, you owned it. For life.
Of course, mental health wasn’t so great back in those days, but I would take that over having my PR blocked all day because Chad, who’s only gift is somehow finding a new hill to die on every day, thinks zero is a “magic number” there’s no way he’s going to budge on this issue.
I pine for those days. It was kind of fun hunting down a bug with git bisect (especially after the pain of SVN) instead of just pointing an agent at it. Not to mention ribbing the new hires or underlings for breaking the build. This new-fangled proompt engineering is boring AF.
> "nobody will be qualified to or really interested in doing the code reviews"
It is a job you know... doing what is necessary to keep yourself qualified is an implicit requirement, and "being interested" is irrelevant. It's work.
I agree with you in principle, but I'm also quite sure that (some) programmer's love for the craft is what keeps the lights on in many companies. It's the usual stereotype, engineers fighting to keep tech debt at bay while management pushes for speed.
The trade has a low bottom, a high ceiling and not a lot of reward for the latter.
If they don't want to do the job, there is a massive crowd of people who are desperately trying to find work right now, and would happily do it in their stead. It's not the 2010s anymore.
It’s hilarious already. People ask for code reviews and two or three people drop in with a bunch of AI code reviews comments from their respective agents. To which, of course, the author has their agent fix those comments. Repeat and repeat. The entire thing is a performance for some authors these days.
> The way forward could involve dropping code reviews altogether.
Yes, if we stop doing quality controls, we don't have the problem of being hung up on quality controls. You do of course have SOC-2 compliance which is a legally auditable attestation, so if you claim you do code review but don't you're committing fraud unless you drop that.
That would be great, IF there were valuable ping-pong between the prompter and the agent. For skilled engineers the game between themselves and the agent is enough. But most people are submitting senseless slop grenades for review.
Claude always comes up with more things to add to the code that are pure bloat and become inbred bombs over several iterations, and some people can't distinguish what suggestions to reject and go along with everything Claude suggests to the detriment of the program #garrytangate
I'm having good luck with the approach of building a thorough requirements specs that are a few pages long, are quite reviewable, and are human written/AI reviewed to prevent it from becoming slop. I call it layered spec driven development, where the one layer is AI read only, and the other layer is the slop layer that AI can play in. The problem is that it requires slowing down just a smidge, which to management these days is more unacceptable than no one having any clue how anything works.
One wild idea is just stop reviewing PRs and instead do continuous review of the entire system guided by heuristics to focus on the riskiest code.
The way you would naturally review an existing codebase is not the same way it grows through individual commits. Therefore, focusing reviews on individual commits is less efficient.
How do you write tests and reviews for code that has yet to be written? And when it is written you have to review the code to write proper tests for it.
Neither one of these replies seems to have the least understanding of what I said.
I'm saying we need to move away from "LGTM" focused PR reviews. Most companies have a PR reviews focused on getting thumbs-up emojis in the comments, then they merge and have a sprint planning. Nobody ever reviews the entire system. Nobody ever asks "assuming there is a mistake in this PR, would it matter? How can we make it so that it wouldn't matter?"
I never claimed AI makes no mistakes. People make mistakes, and reviewers make mistakes too.
I've worked at a lot of mediocre companies where the plan to keep the system working is "the developer will not make a mistake, and the code reviewer will not make a mistake, this is our plan, our plan is humans will not make mistakes, and then our system will continue working". This is like
It's better to ask "let's assume a human (or an AI) does make a mistake, how can we design the system to prevent that from mattering?"
Most companies don't have the capacity to do that though, so they never move beyond thumbs-up emojis. It's all about individual PRs with no sight beyond that.
Agree, many people think code reviews are there to catch "mistakes" (I used to think so too) but I think in most cases, they don't work that way. Bugs are still shipped and, at least in my experience, most reviewers often just quickly skim the changes without paying attention to the details. And those code reviews only give false confidence that a change is OK and must be error-free and good to go just because it was given LGTM by a senior dev (who barely looked at it), with all the consequences of such false confidence. It feels like in 95% of cases review is not even necessary and is just a corporate ritual at this point. It makes sense when you have a fresh contributor and you don't have confidence in them yet (i.e. code review as an onboarding process) or when a certain feature is non-trivial and you aren't sure everyone will be on the same page about the architecture (to prevent future conflicts/disagreements/rewrites of sorts), but other than that, proper QA processes are more important and more effective than CR at catching mistakes (tests, canaries, manual testing too etc.). Our company used to have a strong PR culture but now for a few years, there've been talks that CR is a bottleneck which doesn't really solve the problems it's supposed to solve. My current pipeline with AI-generated code (and my own code too) is that I run AI reviewers several times on a single PR (the way LLMs work, due to attention optimizations, quantization issues, token sampling issues, harness issues -- AI agents often overlook some things on the first attempt), then I assemble the final report and we quickly decide together what needs to be addressed (critical stuff) and what's okay as is. I quickly skim the change set myself too, to see what the shape of the tests is, and what code areas were touched, just to be informed, and that's about it. I don't feel exhausted personally, because it pays off when there's a working feature at the end of the day
I can alter the JavaScript that HN sends me and add all sorts of mistakes to it. My computer will then execute JavaScript that contains mistakes, will that matter?
You saying how mediocre companies feel though. They try really hard to not make mistakes, and then they get pwned and half the nations personal data gets leaked.
Why does AWS IAM exist? If we just don't make mistakes in all our AWS services, we don't need IAM. Let's just not make mistakes.
Truth is, there is A LOT of effort put forth by serious organizations to minimize how much a mistake in one part of the system matters to the rest of the system.
You started out mocking me, "naw bro he thinks that AI will make no mistakes", and now here you are arguing that to be successful we have to ensure that humans don't make mistakes. Do you think that's realistic?
I'm saying it's an economic issue and snakes ruining late-stage capitalism problem more than anything else
Humans can be ultra competent if people are actually paying them to be artisans or otherwise motivating them to truly be that way. That's how we have some of the architecture we have today and historically.
From real-world experience, I have to disagree. It always has been and continues to be a faulty, up-front specification problem. The tail don't wag the dog.
We were there many years ago too though: I had to take over a rather complicated system circa 2012, which had been designed to be built by a team of 20 or so, for timelines, but they had little effort on integration. This meant that a whole lot of guards were written all over the place for situations that, in practice, never occurred. To try to get this to production in a timely fashion, I ended up putting metrics per guard, along with metrics for what was caught by broad error checks near the base of the program. Basically all the defensive programming that had been built was pointless, while I had to write a whole lot of cases that were being dropped, and the people that designed things up front never considered.
AI error handling in code review is a lot like said defensive programming in a vacuum: It'll take a lot of code and a lot of energy, but it's unlikely to be important. Even when you are designing something that gets executed hundreds of millions of times a minute, over-review is easy. You pay for it when letting errors in the real world are unacceptable, but it's pretty inefficient. And that's without getting into features that just don't get used, so the entire thing should not have been built in the first place.
With all respect to your personal experience, I could not possibly disagree more strongly with this.
In my own real world experience, the bottleneck has never been crafting the perfect specification up front. In fact, I have never, not even once, seen the initial specification for any real world software project of any mentionable size or scale survive unscathed to delivery. In reality, it is much like the old wartime maxim. "No Plan Survives First Contact With the Enemy".
The real world is messy and unpredictable. Every single software project of significance that I have been a part of has always involved testing, validating, and reworking the assumptions in the initial design and spec, refining them to arrive at the final product.
Furthermore, this iterative process (pre-AI) used to involve one or more humans following the development story and understanding what design changes and corresponding trade-offs were happening along the way (and why they were being made). By the time there was a finished deliverable ready for review, the person involved was privy to the story of why the development shaped up the way it did. They were able to account for the big picture, adapt accordingly along the way, and be able to explain why things ended up the way they did.
IME, with fully-agentic PRs, AI tends to view the specification as gospel and to view every point of friction between the specification and the real world as something to be worked around or minimized. Where a real human would pause, zoom out, and consider the system and bigger picture, considering what design changes might be needed, the AI will assume that its job is to make the specification a reality at all costs.
You can of course mitigate this by staying more closely involved with the work as it's being done, but this is of course slower than just throwing a spec over the wall and letting an agent run with it. It seems that people are far too eager to optimize for raw speed, and not nearly concerned enough with correctness or human understanding.
A sister comment mentioned a plethora of PRs that don't solve the right problem. If you are swamped with PRs solving the wrong problem, the root cause is not that you didn't foresee every future possibility or undiscovered devil in the details in order to create the right spec, the problem is that you thought you could come up with the right prompt at the outset and that an agent living in a clean digital world could make the journey all the way to a product fit for the messy real world on its own.
I don't think they're talking about "the perfect specification" they're talking about correctly describing what the program should do at all, formally or informally.
If I increased the output of my pump jack and identified the refinery as the new bottleneck would you say the same pithy thing? NB a single pump jack can pump different grades of crude oil at the same time.
I’m not avoiding. But you have to state your assumption that everything before the pipeline is working well and it’s just the refinery that is struggling.
Then your analogy would break down as we all know that the PR machine is a slop producer.
Here’s the thing: a human engineer is embedded in their company. They sit in meetings, they know whose opinions are more important and whose they can disregard. They know the history of how people at the company like to do things. They use all of this context to feed more precise specifications into a coding agent, and as a result, they get an output that better suits the environment of their company. Ergo, they spend less time reviewing agent output which was built to solve the wrong problems in the wrong way, and which ultimately must be discarded or significantly rewritten.
No such thing as a perfect spec, but make a very good one, have a few agents also review there implementation against it, and then actually test the product manually. Gaps and bugs will almost always show during manual testing; skimp on it at your own risk.
what I generally found is that with LLM generated code the best way is to embrace the unix philosophy, create tools that perform singular objectives.
I wound up with a bunch of LLM written tools that I don't even bother to try and understand much less review, they either function as desired or I set an LLM to make them function (or just rewrite them) and then forget about them. make sure to keep a prompt in each tool's directory and update it an needed.
sadly this isn't always possible, some systems require complexity at some level. in those cases the tools from above become functions and objects and more care needs to be taken into orchestrating them to limit the necessity of review. data oriented design approaches and functional programming help here.
Not at all. I have agents review code, as I'm not going to be sifting through all that. I ensure the spec is highly detailed, and there's a review after every feature commit, then a multi-axis review of the range of commits implementing the spec. Then I do manual testing to find gaps and bugs; there, and fleshing out the spec in the first place, is where the bottlenecks are.
This again increases the demand for good programmers.
Write only programmers are dime on dozen. Those who can read code written by others (and themselves) and analyze it are harder to find.
You would hope, though we'll have to see how management actually sifts the chaff from the wheat in practice.
Code reviews have been notoriously neglected. In the most charitable cases, this was the result of being too bogged down with work or some kind of implementation minutia or time-consuming plumbing to have enough time to actually review code with enough care. That and you aren't necessarily rewarded for code reviews by mediocre companies, so there are perverse economic incentives. Which is disconcerting, because it creates a compulsion to produce without understanding, and understanding is more valuable than artifact.
Reading code is indeed more difficult, because the code's intent, composition, and architecture must be pieced together and inferred with the help of context (formalized languages are infamously bad at communicating intent and most code in the world is full of mixed and half-baked abstractions that further serve to obfuscate that intent, and intent is the measure). So a good code review of anything substantial involves thoughtful effort.
Now that LLMs can catch all sorts of trivial anti-patterns, the need for good judgement and reasoning is hopefully made more conspicuous, because as we know, vibe coders will continue to brush off code reviews, and mediocre programmers will continue to perform them poorly.
No, it is quite the opposite. In the scale that AI produces code, it isn't feasible to have humans reviewing it. And, frankly, reviewing code sucks big time.
The solution is to find ways to automate the process of code approval: more thorough tests and reviews, both made by AI.
If reviewing code "sucks big time", then I don't know what to tell you. Reading code is more important than writing it. LLMs can help out with reviews, but it cannot replace human judgement.
> Those who can read code written by others (and themselves) and analyze it are harder to find.
It helps when your industry-wide hiring process isn't an institutionalized speed test of ridiculous code golf problems that is memorized from a ridiculous book by every new generation of programmers.
It's almost like we should have been looking for people who can read code all along. But that would be crazy.
We are using AI to do the first pass at code reviews but they still are a bottleneck. The number of requests has exploded as has the amount of code. More is happening at all stages of the development cycle.
Part of a LinkedIn post I wrote in July:
--
A development cycle of a feature is roughly:
1. Request
2. Review
3. Requirements
4. Architecture
5. Development
6. Code Review
7. UAT
8. Deployment
AI has reduced the length of step 5 (development) and step 6 (code review). Code is a prompt away.
AI has increased top-of-funnel (1) volume. While each development step is shorter on average it is resulting in more instances of every other step. Throughput increases and the bottleneck moves one step further down the cycle. The shape of the work is changing from writing code to reviewing code.
Maybe 6-12 months ago when everyone was reviewing in the same way we did pre AI. Nowadays agents write better code than most developers so it’s more about catching design or integration issues.
I think the bottleneck in the long term will be feature prioritization and specification, and testing. My role has already shifted a lot more into more CI checks to keep LLMs on guardrails
> Nowadays agents write better code than most developers so it’s more about catching design or integration issues.
Maybe most developers are mediocre, but all AI code I review is mediocre at best. Implicit dependencies, side effects, weird naming, bad abstractions, or no abstractions, obfuscated blocks of code that can be expressed much more simply... the point is, AI code is not optimized for human consumption, and I disagree that it is better than human code (or, I have just worked with better than average engineers my whole career).
I really like code review. I might be an exception because a lot of programmers seem not to. Maybe it is from years of reviewing other engineers work and really getting a kick out of having them explain things to me that I dont understand.
Is code review a solution to the problem of human written code or AI generated code? Its not the same thing and we seem to be force fitting an elder years solution to a new problem. Coding is not the same problem it was when code was written by hand. We need to take a systems view here.
Maybe we should just review the prompt(s) the PR author used. Would be nice if this was automated and included in a PR. So code review is really checking that the inputs were valid, and testing the outputs.
This is the wrong way to do it. You should use AI for reviewing as well. Anthropic and OpenAI have good blog posts on how they use AI for reviewing and involve human in the loop only for critical reviews.
I built a system that records numbered design decisions and numbered requirements as claude works in a Postgres database organised as a graph with links/interconnection between items.
It's an MCP server that Claude uses as we develop so there's a permanent record of everything and work is driven by requirements and decisions.
Sorry, I'm not following. What does this graph of design decisions and requirements have to do with architectural design and code quality? And, how is the graph constructed (i.e. what determines what the nodes and vertices are)?
I've seen dozens of those, Claude even suggests building them, and they are all crap after a month. Just updating all the references of decisions becomes onerous. Make one change, it cascades everywhere, eventually all turns to utter crap. The gastown project failed in part due to agents inability to continuously carry context and it kept working on the information system instead of the problems. Good luck to you.
Mine seems fine. The key is that it must be structured as a graph database and anything can link to anything in the graph.
>> Just updating all the references of decisions becomes onerous.
LLMs are good at that sort of thing. Claude is instructed via MCP to ensure changes are linked when it adds or updates the database and to search the graph for relevant information fragments. Also I have a local GPU running a local LLM on an RTX3060/12GB that assists in keeping data quality and relationships relevant and maintained.
My system is an enormous help - in fact large scale development would be impossible without it.
I'm able to ask it the history of things, decisions supersede previous decisions, I can ask why the software behaves the way it does and why and when that decisions was made, I can pick up development threads that have spun off other threads and everything works real nice.
The shift should be to test, code reviews should only be done for critical sections of the app, say db schema, security, UI should start to shift to pure test only and low review. Most business logic should shift to black box tests. Higher level reviews such as Architecture, dependency, complexity analysis should be increased.
I really think ‘shifted the bottleneck to code review’ is misleading. It’s bad code. They write bad code. Yes if you want to salvage it you do a lot of code review, but that’s only because you’ve set your process up to pick spaghetti off the wall against which it has been flung. You could easily just push it all live without review and then pretend the bottleneck is SRE time, or set fire to yourself and claim the bottleneck is emergency service response time. But the root cause is that it’s bad code.
That’s a good take. How do we fix that? My own thought is agents trained on good codebases only. Not sprawling enterprise legacy applications which have long ago spread beyond their original design patterns. What are your thoughts?
I think it’s very hard with the current fine tuning infrastructure available to LLMs. Just like a real team, what you want is to immerse a new member in the domain, understanding that the code is a model of the world that both nourishes and is nourished by the team as you grow together. You want to reach a point where each contributor is intimately aligned on what you’re trying to achieve, and why and how. At that point all your code reviews should be left shifted anyway. But I have not had success putting this in a bunch of markdown files. There is very little infrastructure available for you to, for example, pair with an LLM for a period of time before setting it loose, and we’ve all become too impatient (voluntarily
or by compulsion) to value that anyway.
Software is always human scaled, then made to run at machine speed. Because the needs is ultimately human. And anything human does not change that much fundamentally. Physical laws are even more rigid.
A lot of AI practice fell flat because you can't point out the human needs in them. They powered by dreams and wishes and there nothing that ground them.
I fundamentally think LLMs are the wrong technology for writing code. They can write code, but should they be? If they were just as good as humans, the term "AI slop" would not be so recognizable to software engineers - if there is such a thing as AI slop code, there is such a thing as code quality, and AI does not write a lot of quality code. Now, you can argue that quality code doesn't matter. But words have meaning, and quality usually means code is maintainable, usable, easily refactored (it's software, remember?), and correct. If AI can do all of this as well or better than humans, why is there so much push-back from software engineers against the wide-scale use of AI? One need not look further than many major open source projects to see that people don't want AI slop PRs; so if we really want to automate software engineering, our job is to figure out the delta between AI slop and good-enough code, and make the process of writing good-enough code repeatable.
Vaguely reminiscent of the classic trope around 70's computer "effficiency gains" where a newly introduced computerised accounting system would end up taking longer than the original human-run system because once the computer was through doing the books the original human bookkeeper must still check the results manually.
And just because harvard researchers say something doesn't make it true either. Especially when it's like 6 months late and reviews are probably not the bottleneck anymore - testing, ci, parallelization are (imo).
"The thing that can spit out endless amounts of code purely based on small text prompts is generating more code than can be reviewed." Lol top notch research. Thank you, Harvard.
I find funny that every time we discuss code made by AI people's reaction is to nurture some feeling of "someday, somehow they'll regret Claude Code and come back to me".
I suspect that the old assembly programmers had the same hope and feeling about the first higher level compilers for Ada, Pascal and C. And guess what? There are very few assembly programmers these days.
AI code is here to stay and will only grow. Deal with it. More than in any other area it is quite silly to be a Luddite in IT.
I've submitted the original paper (https://fion.ac/jellyfish.pdf), but others already have to little engagement, likely due to the paper's terrible title.
This just doesn't make sense. If AI is really smarter than humans we wouldn't need to review it. If it's not than why would the bottleneck shift, we shouldn't be doing this tradeoff between more reviews vs. writing code.
It's baffling the industry is choosing to move in the direction of more reviews which implies more things can fail.
Is their code reviewed by a junior, or another engineer on their level? That's the point, if AI is MORE intelligent/capable than humans, it follows we would have another AI review it.
It's just the latest attempt in bringing developer wages down.
There's decades worth of this: modelling, automatic code generation, low-code / no-code saas, "everyone should learn to code" and now llms.
Oh, and ageism of course. "we love your experience but we just don't feel it's a good cultural fit, so we're going to make the same mistakes you did a generation ago"
All I do all day is review ai written code. my own or teammates. I really do not enjoy it.
It's decision fatigue. The decisions used to broken up by stretches of coding, now it's the whole job. It's exhausting.
I wrote a tool to do local code review of LLM written code.
https://github.com/imron/crt
You can leave comments on the code and then get your agent to connect over MCP to read the comments with context and work on corrections.
It then remembers what you have already reviewed and only shows you diffs for the changes.
Still a WIP, but works well for me.
Plus the task may be judging the "decisions" of a different kind of "contributor" than fellow humans, and often there's no social payoff for interacting and no trust that the contributor will internalize what you said and improve the next time.
100% nailed it.
I think this is a muscle that grows though. Making decisions about schema changes in the past may have taken weeks, but if you're doing it once or twice a week you gradually gain confidence in your judgment.
>I think this is a muscle that grows though.
Does it really though? Before I had to think hard before committing to a decision, because it took work to actually implement it. And when it turned out to be wrong, I retained how it went wrong. It made the "muscle" grow.
Now I can commit to a decision without much thought (yea, just nodding along with the AI), and if it turns out to be wrong, I can quickly try an alternative. In fact, my boss would want to quickly try an alternative, instead of letting the programmer learn something out of it for fear of slowing down the AI...
So does the decision making muscle really grow?
Can one make decisions faster? With less fatigue? It seems like a very human, hard-to-overcome limit.
I find it extremely exhausting. And the better the AI code gets, the more tempting it is to do a very shallow review or skip it entirely. In the end, it's very similar to dealing with offshore teams. You spend an enormous amount of time and energy on writing specifications and you spend a lot of energy on code reviews. If you don't do that, it's very likely the project will slowly go off the rails.
I have no idea how the Linux maintainers do that job over a long time.
The irony is that I actually don't mind reviewing code, but I've already taken that step out of the equation using a set of guidelines I've developed over the past year working with these things. The vast majority of which I have barely reviewed code in. In well-working results.
Your goal should be to automate and remove yourself out of the process as much as possible while maintaining quality, while also remaining confident that you will still be valuable.
I don't even review it.
Don't. If you try that shit, someone is not going to like that you would be slowing down the AI. Because out there, someone is going to outrun you by skipping reviews. That is how the leadership thinks..
You're reviewing _something_ at the end of the day. (Unless you are somehow magically one-shotting problems) If you are reviewing the description of the work, or reviewing the functionality of the app.
I know it's not the same as code, but it is similarly exhausting
I don't always test my code, but when I do, I do it in production.
So do you work for JPMorgan, the NSA, FAA or an airline?
kids these days don't even know about CrowdStrike
As long as stakes are high and human have to sign off quality and are held responsible for any faulty release, no one will be willing to speed this up.
A lot of this university research on AI feels dated. This is something we all faced months ago. Many times they're also reaching conclusions using obsolete models, etc. Feels like things move too fast for traditional research cycles to catch up to AI dev
I think you are way overestimating the speed of diffusion into non-SV companies.
I was sitting with someone the other day who worked at a major ecommerce/media company (outside the US). They had access to Opus 4.5 via Co-pilot.
Oof, that must be a hefty bill for that company. Any older tier model is prized multiples. Believe you see it with every provider.
My partner's company positions themselves as "powered by AI" in their marketing.
Back in reality, this means they have a corporate subscription to Copilot, which she doesn't use.
Its not resolved though, by any measure, except by removing human code review and coherence at the code level. Which is a pretty big tradeoff that has some at this point well-known downsides.
hard to know where to start here. but I think it is sufficient to say you seem to misunderstand the fundamental purpose and process of academic research and may wish to avoid commenting on it until you do.
Agreed, by the time the study is done, they're studying the well established and past.
Of course for industries and corporate it might not be an issue.
Not that I think most academic research is worth the time consumed producing it, but it feels dated because it actually takes time to do research instead of just rapidly changing direction based on feels, which is what developers are currently doing. It's the intellectual rigor of javascript frameworks, but with slop cannons.
In particular, code review is not solved. Pointing another error-prone bot at the output of your first error-prone bot, and then pressing "Enter" if the test suite passes, is not a solution. But you have to do it, because the next guy will beat you to prod if you don’t. And before too long, I'm sure that pressing Enter will be the bottleneck...
Right now what we have is a prisoner’s dilemma, where you can’t be slower than the guy next to you. So we rationalize slop and call it innovation.
Exactly. What a weird clickbait title to come out of a Tier 1 institution. You have Harvard PhD's concluding this!? This is what a PhD at that insitution is putting out? That is really sad. FTA:
The paper’s interviews show what that looks like on a team: a junior software engineer described a project where only one senior engineer could approve changes and could review the interviewee’s code only once a week.
So the issue is not AI. The issue is organizations and certain personalities who think that a human is going to be a better coder than an engineer. At this point rolling and writing your own code is akin to making up your own encryption scheme.
The problem is that when nobody writes code or feels ownership over it anymore, nobody will be qualified to or really interested in doing the code reviews. The way forward could involve dropping code reviews altogether. You could argue that the useful pingpong between coder and reviewers has been replaced by the similar pingpong between the prompter and the agent.
In my company, people found out that if they use an agent that commits and do the pull/merge request, they can approve it themselves and bypass a second set of eyes.
Since they are the one doing the prompting, they quickly got lazy of actually reviewing the output from the LLM which means that nobody is reviewing anything.
It hasn't happened yet but I guess that is how you end up with major outages.
This is everywhere to my knowledge, and engineers are burning out left and right with stress because of how little anyone understands the code, and how much of a mountain of nobody knowing anything they have to handle. We are turning our critical infrastructure mechanisms into stochastic grey goo.
I find the engineers currently thriving are the ones who never gave a fuck about anything but their own advancement and are happy to drop weeks of work on others and take the credit.
> how little anyone understands the code
Everyone's doing code reviews--well, not even code reviews; just PR reviews--so how are they supposed to gain an understanding of the system.
I review a PR, I see that one new endpoint was added to the API. It looks correct. I say "LGTM" in a GitHub comment.
The sprint's almost over, everyone's in a rush to do code reviews.
I look at another PR. Somebody added a button to the UI. The button looks correct, it's connect to some callbacks that look correct. They get a thumbs-up emoji from me. I bet they feel satisfied.
I look at another PR. Somebody changed a timeout in the settings because some people complained about dropped connections. It's a really small change, so, approved.
At what point am I supposed to understand the system? I looked at a single API endpoint, in isolation, and then a button, and then a harmless looking settings change.
I was pressured to hurry.
Am I supposed to somehow get an understanding of the big picture through this?
Imagine if instead there was time to review large logical sections of the code together. Imagine if we focused our reviews on the overall code instead of on the lines in one random PR at a time.
Understanding is overrated, application code (user-space) is anyway just a way to make money. If you're making more money over time, you're doing it right. We're not writing kernel code or safety critical code, we can let AI do the heavy lifting of putting characters into a file.
This comment is crystaline perfection. I could not more clearly state the soul sucking ethos of AI hype that makes me want to walk into the sea.
> If you're making more money over time, you're doing it right.
You are doing it right. But the people who are giving you the money; They are doing it WRONG.
"We're not writing kernel code or safety critical code"
I do. There is a lot of code out there that needs to work correctly or it will have serious consequences. Payments, inventory tracking, medical stuff, payroll. Many, many areas where it just needs to work.
There are plenty of apps that while not safety critical, are financially critical to people's lives. When you're working on an app that processes billions of dollars in payments per month you can't just yolo it.
It’s funny that anyone still thinks that these practices aren’t being applied to safety critical code in order to make money.
I can confirm you that they are.
I can confirm you that they aren't.
This is why we need to resurrect the neglected git-blame and go back to the days of git-before-GitHub. Way back in the old timey days of 2009-ish, just before the Dawn of the Pull Request, code reviews were seldom. Maybe you’d all get a conference room and talk about architecting some new thing or whatever, but none of this endless nit-picking bullshit that came later. And there were no branch protections, anyone could crap all over the main branch (nee: master) anytime they wanted. Boy, those were some wild times, let me tell ya!
Truth be told, it was the firm hand of the git blame-and-shame that kept our code civil and orderly. Binding contract written in blood was “the name on the blame owns the change”. If you pushed it, you owned it. For life.
Of course, mental health wasn’t so great back in those days, but I would take that over having my PR blocked all day because Chad, who’s only gift is somehow finding a new hill to die on every day, thinks zero is a “magic number” there’s no way he’s going to budge on this issue.
I pine for those days. It was kind of fun hunting down a bug with git bisect (especially after the pain of SVN) instead of just pointing an agent at it. Not to mention ribbing the new hires or underlings for breaking the build. This new-fangled proompt engineering is boring AF.
The compressed timelines which result when leadership sees how quickly code can be produced becomes pressure on the reviewer to not be a blocker.
Reviewers are the most burnt out right now
Seems like a way for the ones churning out the code to push responsibility onto reviewers.
> The way forward could involve dropping code reviews altogether.
I unironically agree. At least, the current form of code reviews needs to go.
Currently we spend all effort reviewing individual changes and no effort reviewing the entire system, or the underlying dependencies.
If you sat down to learn a legacy codebase, you would not review it in the order of commits. Reviewing individual commits is inefficient.
It would be better to have an entire team of reviewers systematically reviewing ALL the code, over and over, including the code of dependencies.
We need better tooling and heuristics to help focus review efforts on the code that is most risky.
> "nobody will be qualified to or really interested in doing the code reviews"
It is a job you know... doing what is necessary to keep yourself qualified is an implicit requirement, and "being interested" is irrelevant. It's work.
I agree with you in principle, but I'm also quite sure that (some) programmer's love for the craft is what keeps the lights on in many companies. It's the usual stereotype, engineers fighting to keep tech debt at bay while management pushes for speed.
The trade has a low bottom, a high ceiling and not a lot of reward for the latter.
If they don't want to do the job, there is a massive crowd of people who are desperately trying to find work right now, and would happily do it in their stead. It's not the 2010s anymore.
> The way forward could involve dropping code reviews altogether. Y
It seems that the human involvement is the new "unit testing". There was a period of time when management that it was superfluous.
I can't wait for the pendulum to swing back in full force.
It’s hilarious already. People ask for code reviews and two or three people drop in with a bunch of AI code reviews comments from their respective agents. To which, of course, the author has their agent fix those comments. Repeat and repeat. The entire thing is a performance for some authors these days.
> The way forward could involve dropping code reviews altogether.
Yes, if we stop doing quality controls, we don't have the problem of being hung up on quality controls. You do of course have SOC-2 compliance which is a legally auditable attestation, so if you claim you do code review but don't you're committing fraud unless you drop that.
That would be great, IF there were valuable ping-pong between the prompter and the agent. For skilled engineers the game between themselves and the agent is enough. But most people are submitting senseless slop grenades for review.
Claude always comes up with more things to add to the code that are pure bloat and become inbred bombs over several iterations, and some people can't distinguish what suggestions to reject and go along with everything Claude suggests to the detriment of the program #garrytangate
I'm having good luck with the approach of building a thorough requirements specs that are a few pages long, are quite reviewable, and are human written/AI reviewed to prevent it from becoming slop. I call it layered spec driven development, where the one layer is AI read only, and the other layer is the slop layer that AI can play in. The problem is that it requires slowing down just a smidge, which to management these days is more unacceptable than no one having any clue how anything works.
One wild idea is just stop reviewing PRs and instead do continuous review of the entire system guided by heuristics to focus on the riskiest code.
The way you would naturally review an existing codebase is not the same way it grows through individual commits. Therefore, focusing reviews on individual commits is less efficient.
We need better tooling and a better approach.
How do you write tests and reviews for code that has yet to be written? And when it is written you have to review the code to write proper tests for it.
naw bro he thinks that AI will make no mistakes
Neither one of these replies seems to have the least understanding of what I said.
I'm saying we need to move away from "LGTM" focused PR reviews. Most companies have a PR reviews focused on getting thumbs-up emojis in the comments, then they merge and have a sprint planning. Nobody ever reviews the entire system. Nobody ever asks "assuming there is a mistake in this PR, would it matter? How can we make it so that it wouldn't matter?"
I never claimed AI makes no mistakes. People make mistakes, and reviewers make mistakes too.
I've worked at a lot of mediocre companies where the plan to keep the system working is "the developer will not make a mistake, and the code reviewer will not make a mistake, this is our plan, our plan is humans will not make mistakes, and then our system will continue working". This is like
It's better to ask "let's assume a human (or an AI) does make a mistake, how can we design the system to prevent that from mattering?"
Most companies don't have the capacity to do that though, so they never move beyond thumbs-up emojis. It's all about individual PRs with no sight beyond that.
Agree, many people think code reviews are there to catch "mistakes" (I used to think so too) but I think in most cases, they don't work that way. Bugs are still shipped and, at least in my experience, most reviewers often just quickly skim the changes without paying attention to the details. And those code reviews only give false confidence that a change is OK and must be error-free and good to go just because it was given LGTM by a senior dev (who barely looked at it), with all the consequences of such false confidence. It feels like in 95% of cases review is not even necessary and is just a corporate ritual at this point. It makes sense when you have a fresh contributor and you don't have confidence in them yet (i.e. code review as an onboarding process) or when a certain feature is non-trivial and you aren't sure everyone will be on the same page about the architecture (to prevent future conflicts/disagreements/rewrites of sorts), but other than that, proper QA processes are more important and more effective than CR at catching mistakes (tests, canaries, manual testing too etc.). Our company used to have a strong PR culture but now for a few years, there've been talks that CR is a bottleneck which doesn't really solve the problems it's supposed to solve. My current pipeline with AI-generated code (and my own code too) is that I run AI reviewers several times on a single PR (the way LLMs work, due to attention optimizations, quantization issues, token sampling issues, harness issues -- AI agents often overlook some things on the first attempt), then I assemble the final report and we quickly decide together what needs to be addressed (critical stuff) and what's okay as is. I quickly skim the change set myself too, to see what the shape of the tests is, and what code areas were touched, just to be informed, and that's about it. I don't feel exhausted personally, because it pays off when there's a working feature at the end of the day
"how can we design the system to prevent that from mattering"
you can't
there is no way around it
we need far more review than we economically are motivated to sustain
and hence issues like we've been having over the past week will continue and perhaps worsen
software will (as it already has been) get crappier and crappier overtime
I can alter the JavaScript that HN sends me and add all sorts of mistakes to it. My computer will then execute JavaScript that contains mistakes, will that matter?
You saying how mediocre companies feel though. They try really hard to not make mistakes, and then they get pwned and half the nations personal data gets leaked.
Why does AWS IAM exist? If we just don't make mistakes in all our AWS services, we don't need IAM. Let's just not make mistakes.
Truth is, there is A LOT of effort put forth by serious organizations to minimize how much a mistake in one part of the system matters to the rest of the system.
You started out mocking me, "naw bro he thinks that AI will make no mistakes", and now here you are arguing that to be successful we have to ensure that humans don't make mistakes. Do you think that's realistic?
I'm saying it's an economic issue and snakes ruining late-stage capitalism problem more than anything else
Humans can be ultra competent if people are actually paying them to be artisans or otherwise motivating them to truly be that way. That's how we have some of the architecture we have today and historically.
That's why you add "make no mistakes" to the end of your prompt.
From real-world experience, I have to disagree. It always has been and continues to be a faulty, up-front specification problem. The tail don't wag the dog.
Very true. Which makes the conclusion reached be this study even worse: we are stuck reviewing endless PRs that solve the wrong problems.
We were there many years ago too though: I had to take over a rather complicated system circa 2012, which had been designed to be built by a team of 20 or so, for timelines, but they had little effort on integration. This meant that a whole lot of guards were written all over the place for situations that, in practice, never occurred. To try to get this to production in a timely fashion, I ended up putting metrics per guard, along with metrics for what was caught by broad error checks near the base of the program. Basically all the defensive programming that had been built was pointless, while I had to write a whole lot of cases that were being dropped, and the people that designed things up front never considered.
AI error handling in code review is a lot like said defensive programming in a vacuum: It'll take a lot of code and a lot of energy, but it's unlikely to be important. Even when you are designing something that gets executed hundreds of millions of times a minute, over-review is easy. You pay for it when letting errors in the real world are unacceptable, but it's pretty inefficient. And that's without getting into features that just don't get used, so the entire thing should not have been built in the first place.
With all respect to your personal experience, I could not possibly disagree more strongly with this.
In my own real world experience, the bottleneck has never been crafting the perfect specification up front. In fact, I have never, not even once, seen the initial specification for any real world software project of any mentionable size or scale survive unscathed to delivery. In reality, it is much like the old wartime maxim. "No Plan Survives First Contact With the Enemy".
The real world is messy and unpredictable. Every single software project of significance that I have been a part of has always involved testing, validating, and reworking the assumptions in the initial design and spec, refining them to arrive at the final product.
Furthermore, this iterative process (pre-AI) used to involve one or more humans following the development story and understanding what design changes and corresponding trade-offs were happening along the way (and why they were being made). By the time there was a finished deliverable ready for review, the person involved was privy to the story of why the development shaped up the way it did. They were able to account for the big picture, adapt accordingly along the way, and be able to explain why things ended up the way they did.
IME, with fully-agentic PRs, AI tends to view the specification as gospel and to view every point of friction between the specification and the real world as something to be worked around or minimized. Where a real human would pause, zoom out, and consider the system and bigger picture, considering what design changes might be needed, the AI will assume that its job is to make the specification a reality at all costs.
You can of course mitigate this by staying more closely involved with the work as it's being done, but this is of course slower than just throwing a spec over the wall and letting an agent run with it. It seems that people are far too eager to optimize for raw speed, and not nearly concerned enough with correctness or human understanding.
A sister comment mentioned a plethora of PRs that don't solve the right problem. If you are swamped with PRs solving the wrong problem, the root cause is not that you didn't foresee every future possibility or undiscovered devil in the details in order to create the right spec, the problem is that you thought you could come up with the right prompt at the outset and that an agent living in a clean digital world could make the journey all the way to a product fit for the messy real world on its own.
I don't think they're talking about "the perfect specification" they're talking about correctly describing what the program should do at all, formally or informally.
I don't fully disagree with you. That is a real big problem.
But both things can be true. One problem doesn't exclude the other.
> The tail don't wag the dog
If I increased the output of my pump jack and identified the refinery as the new bottleneck would you say the same pithy thing? NB a single pump jack can pump different grades of crude oil at the same time.
You may need to check the pipeline so that the refinery isn't stuck filtering random stuff from the oil.
AKA, it would be nice to have nice patches like this one to review.
https://cgit.freebsd.org/src/commit/?id=09d62ba33de113d01e88...
you're avoiding the question: If I increased the output of my pump jack and identified the refinery as the new bottleneck would you say i was wrong?
I’m not avoiding. But you have to state your assumption that everything before the pipeline is working well and it’s just the refinery that is struggling.
Then your analogy would break down as we all know that the PR machine is a slop producer.
So the solution is: write a perfect spec and then you'll have perfect code, no need for reviews?
What world do y'all live in where this is your reality?
Here’s the thing: a human engineer is embedded in their company. They sit in meetings, they know whose opinions are more important and whose they can disregard. They know the history of how people at the company like to do things. They use all of this context to feed more precise specifications into a coding agent, and as a result, they get an output that better suits the environment of their company. Ergo, they spend less time reviewing agent output which was built to solve the wrong problems in the wrong way, and which ultimately must be discarded or significantly rewritten.
No such thing as a perfect spec, but make a very good one, have a few agents also review there implementation against it, and then actually test the product manually. Gaps and bugs will almost always show during manual testing; skimp on it at your own risk.
what I generally found is that with LLM generated code the best way is to embrace the unix philosophy, create tools that perform singular objectives.
I wound up with a bunch of LLM written tools that I don't even bother to try and understand much less review, they either function as desired or I set an LLM to make them function (or just rewrite them) and then forget about them. make sure to keep a prompt in each tool's directory and update it an needed.
sadly this isn't always possible, some systems require complexity at some level. in those cases the tools from above become functions and objects and more care needs to be taken into orchestrating them to limit the necessity of review. data oriented design approaches and functional programming help here.
Not at all. I have agents review code, as I'm not going to be sifting through all that. I ensure the spec is highly detailed, and there's a review after every feature commit, then a multi-axis review of the range of commits implementing the spec. Then I do manual testing to find gaps and bugs; there, and fleshing out the spec in the first place, is where the bottlenecks are.
This again increases the demand for good programmers. Write only programmers are dime on dozen. Those who can read code written by others (and themselves) and analyze it are harder to find.
There's no increase in demand until management who would hire them realizes how much trouble they're in.
You would hope, though we'll have to see how management actually sifts the chaff from the wheat in practice.
Code reviews have been notoriously neglected. In the most charitable cases, this was the result of being too bogged down with work or some kind of implementation minutia or time-consuming plumbing to have enough time to actually review code with enough care. That and you aren't necessarily rewarded for code reviews by mediocre companies, so there are perverse economic incentives. Which is disconcerting, because it creates a compulsion to produce without understanding, and understanding is more valuable than artifact.
Reading code is indeed more difficult, because the code's intent, composition, and architecture must be pieced together and inferred with the help of context (formalized languages are infamously bad at communicating intent and most code in the world is full of mixed and half-baked abstractions that further serve to obfuscate that intent, and intent is the measure). So a good code review of anything substantial involves thoughtful effort.
Now that LLMs can catch all sorts of trivial anti-patterns, the need for good judgement and reasoning is hopefully made more conspicuous, because as we know, vibe coders will continue to brush off code reviews, and mediocre programmers will continue to perform them poorly.
No, it is quite the opposite. In the scale that AI produces code, it isn't feasible to have humans reviewing it. And, frankly, reviewing code sucks big time.
The solution is to find ways to automate the process of code approval: more thorough tests and reviews, both made by AI.
If reviewing code "sucks big time", then I don't know what to tell you. Reading code is more important than writing it. LLMs can help out with reviews, but it cannot replace human judgement.
> Those who can read code written by others (and themselves) and analyze it are harder to find.
It helps when your industry-wide hiring process isn't an institutionalized speed test of ridiculous code golf problems that is memorized from a ridiculous book by every new generation of programmers.
It's almost like we should have been looking for people who can read code all along. But that would be crazy.
This feels obvious to me, but it's interesting how so many people feel the opposite.
I guess it depends a lot on how a company manages their SDLC/bureaucracy
If someone doesn't think code review is the bottleneck, chances are they've got AI doing their code reviews too.
We are using AI to do the first pass at code reviews but they still are a bottleneck. The number of requests has exploded as has the amount of code. More is happening at all stages of the development cycle.
Part of a LinkedIn post I wrote in July:
--
A development cycle of a feature is roughly:
1. Request
2. Review
3. Requirements
4. Architecture
5. Development
6. Code Review
7. UAT
8. Deployment
AI has reduced the length of step 5 (development) and step 6 (code review). Code is a prompt away.
AI has increased top-of-funnel (1) volume. While each development step is shorter on average it is resulting in more instances of every other step. Throughput increases and the bottleneck moves one step further down the cycle. The shape of the work is changing from writing code to reviewing code.
Harvard researchers found a tree in a forest
Weird, to me it seemed like that's always where the bottleneck was ..
It's also weird that we need either "Harvard" or "researchers" to tell us something so fucking obvious.
Maybe 6-12 months ago when everyone was reviewing in the same way we did pre AI. Nowadays agents write better code than most developers so it’s more about catching design or integration issues.
I think the bottleneck in the long term will be feature prioritization and specification, and testing. My role has already shifted a lot more into more CI checks to keep LLMs on guardrails
> Nowadays agents write better code than most developers so it’s more about catching design or integration issues.
Maybe most developers are mediocre, but all AI code I review is mediocre at best. Implicit dependencies, side effects, weird naming, bad abstractions, or no abstractions, obfuscated blocks of code that can be expressed much more simply... the point is, AI code is not optimized for human consumption, and I disagree that it is better than human code (or, I have just worked with better than average engineers my whole career).
I really like code review. I might be an exception because a lot of programmers seem not to. Maybe it is from years of reviewing other engineers work and really getting a kick out of having them explain things to me that I dont understand.
Is code review a solution to the problem of human written code or AI generated code? Its not the same thing and we seem to be force fitting an elder years solution to a new problem. Coding is not the same problem it was when code was written by hand. We need to take a systems view here.
With how much code AI can write in such a short period of time, code review and system design are really the only things left to do.
Maybe we should just review the prompt(s) the PR author used. Would be nice if this was automated and included in a PR. So code review is really checking that the inputs were valid, and testing the outputs.
For a given feature my list of prompts looks like:
- very well defined initial description of problem plus asking exactly what i want
- fix X
- why do you claim that Y?
- fix Y
- …
I don’t think it would be useful to review or commit prompts
This is the wrong way to do it. You should use AI for reviewing as well. Anthropic and OpenAI have good blog posts on how they use AI for reviewing and involve human in the loop only for critical reviews.
Test don't review.
That bottlenecks too, in startup ahead of the adoption curve the whole cicd pipeline down to how to merge is being rethought
What about design decisions or code quality? Tests don't cover those.
If it ain't testable or can't be automatically enforced with some other form of guardrails then it doesn't matter.
I built a system that records numbered design decisions and numbered requirements as claude works in a Postgres database organised as a graph with links/interconnection between items.
It's an MCP server that Claude uses as we develop so there's a permanent record of everything and work is driven by requirements and decisions.
Sorry, I'm not following. What does this graph of design decisions and requirements have to do with architectural design and code quality? And, how is the graph constructed (i.e. what determines what the nodes and vertices are)?
I've seen dozens of those, Claude even suggests building them, and they are all crap after a month. Just updating all the references of decisions becomes onerous. Make one change, it cascades everywhere, eventually all turns to utter crap. The gastown project failed in part due to agents inability to continuously carry context and it kept working on the information system instead of the problems. Good luck to you.
>> they are all crap after a month
Mine seems fine. The key is that it must be structured as a graph database and anything can link to anything in the graph.
>> Just updating all the references of decisions becomes onerous.
LLMs are good at that sort of thing. Claude is instructed via MCP to ensure changes are linked when it adds or updates the database and to search the graph for relevant information fragments. Also I have a local GPU running a local LLM on an RTX3060/12GB that assists in keeping data quality and relationships relevant and maintained.
My system is an enormous help - in fact large scale development would be impossible without it.
I'm able to ask it the history of things, decisions supersede previous decisions, I can ask why the software behaves the way it does and why and when that decisions was made, I can pick up development threads that have spun off other threads and everything works real nice.
>> Good luck to you.
Thank you!
You could argue that the code quality is irrelevant since code is cheap now. Not saying I personally agree with this, I've just heard it.
Architecture and design decisions may be the only things that matter.
Equally time consuming and mind-numbing, IMO.
They're the same picture
No pull request in my company get any human review comments anymore. No one is reading.
It's also hard to blame reviewers, when often that phase is preceded by the supposed "authors" not truly reading the reviews.
We have a PR template that has a checkbox that says "I have read this code".
A lot of the time it does not get checked.
The shift should be to test, code reviews should only be done for critical sections of the app, say db schema, security, UI should start to shift to pure test only and low review. Most business logic should shift to black box tests. Higher level reviews such as Architecture, dependency, complexity analysis should be increased.
That's sort of old news. Code isn't manually reviewed anymore much.
I really think ‘shifted the bottleneck to code review’ is misleading. It’s bad code. They write bad code. Yes if you want to salvage it you do a lot of code review, but that’s only because you’ve set your process up to pick spaghetti off the wall against which it has been flung. You could easily just push it all live without review and then pretend the bottleneck is SRE time, or set fire to yourself and claim the bottleneck is emergency service response time. But the root cause is that it’s bad code.
That’s a good take. How do we fix that? My own thought is agents trained on good codebases only. Not sprawling enterprise legacy applications which have long ago spread beyond their original design patterns. What are your thoughts?
I think it’s very hard with the current fine tuning infrastructure available to LLMs. Just like a real team, what you want is to immerse a new member in the domain, understanding that the code is a model of the world that both nourishes and is nourished by the team as you grow together. You want to reach a point where each contributor is intimately aligned on what you’re trying to achieve, and why and how. At that point all your code reviews should be left shifted anyway. But I have not had success putting this in a bunch of markdown files. There is very little infrastructure available for you to, for example, pair with an LLM for a period of time before setting it loose, and we’ve all become too impatient (voluntarily or by compulsion) to value that anyway.
Software is always human scaled, then made to run at machine speed. Because the needs is ultimately human. And anything human does not change that much fundamentally. Physical laws are even more rigid.
A lot of AI practice fell flat because you can't point out the human needs in them. They powered by dreams and wishes and there nothing that ground them.
I fundamentally think LLMs are the wrong technology for writing code. They can write code, but should they be? If they were just as good as humans, the term "AI slop" would not be so recognizable to software engineers - if there is such a thing as AI slop code, there is such a thing as code quality, and AI does not write a lot of quality code. Now, you can argue that quality code doesn't matter. But words have meaning, and quality usually means code is maintainable, usable, easily refactored (it's software, remember?), and correct. If AI can do all of this as well or better than humans, why is there so much push-back from software engineers against the wide-scale use of AI? One need not look further than many major open source projects to see that people don't want AI slop PRs; so if we really want to automate software engineering, our job is to figure out the delta between AI slop and good-enough code, and make the process of writing good-enough code repeatable.
Review and testing, really. And soon agents will do most review and testing, and then we can only pray that nothing will break
It is very bold of them to assume people are reviewing code. People nowadays are just triggering an agentic review manually.
This does not spark joy.
Vaguely reminiscent of the classic trope around 70's computer "effficiency gains" where a newly introduced computerised accounting system would end up taking longer than the original human-run system because once the computer was through doing the books the original human bookkeeper must still check the results manually.
We needed a research paper to tell us this?
Just because it is obviously true to you, it doesn't mean it is obviously true to others.
And just because it is obviously true to you, it doesn't mean that it is true, either.
And just because harvard researchers say something doesn't make it true either. Especially when it's like 6 months late and reviews are probably not the bottleneck anymore - testing, ci, parallelization are (imo).
Paraphrasing one of my favorite movie quotes: "Well ain't this a temporal anomaly. 6 months from any criticism!"
A Havard research I'll have you know! /s
do you even have a PhD?
(/s)
Breaking news: Step A has been automated, so step B is now the bottleneck
Welcome to at least 1 year ago??
"code is cheap"...if you don't need to understand, review, and maintain it as part of a team.
news flash?
I'm being told the answer is simply to let AI review and merge the code. Problem solved.
This, but unironically.
Good luck when you get woken up at the middle of the night for an outage!
Did this never happen before AI? Are we sure it happens more now, especially relative to the number of features being shipped?
"The thing that can spit out endless amounts of code purely based on small text prompts is generating more code than can be reviewed." Lol top notch research. Thank you, Harvard.
And in other news, water isn't wet.
Wow so glad the great minds at Harvard were able to figure this out about year later than anyone who works in industry. Great job guys!
It took Harvard researches to find this lol?
Harward researcher read lovable blog post
I find funny that every time we discuss code made by AI people's reaction is to nurture some feeling of "someday, somehow they'll regret Claude Code and come back to me".
I suspect that the old assembly programmers had the same hope and feeling about the first higher level compilers for Ada, Pascal and C. And guess what? There are very few assembly programmers these days.
AI code is here to stay and will only grow. Deal with it. More than in any other area it is quite silly to be a Luddite in IT.
But people keep saying "coding was never the bottleneck!".
I've submitted the original paper (https://fion.ac/jellyfish.pdf), but others already have to little engagement, likely due to the paper's terrible title.
In other news, Dartmouth researchers find the sky is blue.
This just doesn't make sense. If AI is really smarter than humans we wouldn't need to review it. If it's not than why would the bottleneck shift, we shouldn't be doing this tradeoff between more reviews vs. writing code.
It's baffling the industry is choosing to move in the direction of more reviews which implies more things can fail.
"If AI is really smarter than humans we wouldn't need to review it."
Does the smartest person on your team not have their code reviewed?
Is their code reviewed by a junior, or another engineer on their level? That's the point, if AI is MORE intelligent/capable than humans, it follows we would have another AI review it.
Their intelligence is not like ours. Frontier models still make dumb mistakes.
Exactly, now the question is how much is different because it determines what the tradeoffs are in order to commit to a new workflow.
No one said it's smarter than humans, and AI currently is better at code review than I am. It finds all kinds of edge cases I would have missed.
Still, humans are needed for the final sign-off for testing on real devices and making sure it works within the greater cultural context.
Alright, so if AI is better at code review than you, it follows you are not reviewing anymore, right? Otherwise that's the gap I'm pointing at.
It's just the latest attempt in bringing developer wages down.
There's decades worth of this: modelling, automatic code generation, low-code / no-code saas, "everyone should learn to code" and now llms.
Oh, and ageism of course. "we love your experience but we just don't feel it's a good cultural fit, so we're going to make the same mistakes you did a generation ago"